Fix in-app-menu squishing sub-menu items #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when using the
in-app-menuplugin, menu children at the bottom of the screen would get squished, especially when there were multiple layers of children:Show Image
This fixes this by checking if a child menu can scroll (meaning it is squished), and instead positioning it by the bottom of the element:
Show Image
The
max-heightproperty is also adjusted to prevent the menu from going off of the screen.The only potential caveat is that long child menus near the top of the screen will actually have their size reduced, but I don't think this is a real problem as none of the menus (that I know of) are like this:
Show Image