Add custom equalizer plugin with presets (bass booster, rock...) and the ability to add your own presets via a config.json file #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd recommend you split this into multiple smaller files, one for menu, one for renderer and one for the presets would be a good way of splitting this. |
|
The code is quite small, so I think splitting it into multiple files might be unnecessary. Also, I haven't fully figured out how to do it properly yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Custom Equalizer plugin for EQ settings with a large selection of default presets, and the ability to make your own flexible presets with detailed settings and any number of BiquadFilter. There is no UI, custom presets are added via a config.json file.