Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade libs, node 20 #16

Closed
wants to merge 1 commit into from
Closed

chore: upgrade libs, node 20 #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
12.20.0
20
14 changes: 7 additions & 7 deletions action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ name: 'Workflow Dispatch and wait'
description: 'Trigger and chain GitHub Actions workflows with workflow_dispatch events and wait for result'

inputs:
workflow:
workflow:
description: 'Name or ID of workflow to run'
required: true
token:
token:
description: 'GitHub token with repo write access, can NOT use secrets.GITHUB_TOKEN, see readme'
required: true
inputs:
Expand All @@ -23,7 +23,7 @@ inputs:
display-workflow-run-url:
description: 'Get the URL of the triggered workflow and display it in logs (useful to follow the progress of the triggered workflow)'
required: false
default: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add quotes ? It should be a boolean value

Copy link

@figroc figroc Feb 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this line be changed? https://github.com/aurelien-baudet/workflow-dispatch/blob/c2b3c6dfb91343cf66073ac553e613483b046e1c/src/utils.ts#L44

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, why ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be a boolean value

Looking at the schema, the type of default is string. However, I don't think it will actually change any behaviour as GHA likely coerces it into a string anyway. This StackOverflow answer may also help explain.

It may be worth adding the quotes if only to avoid your editor showing a syntax error, but it should probably then use single-quotes to be consistent with the rest of the file.

Should this line be changed?

I also don't think this line should be changed. Whether the input is processed as a string or boolean is dependent on whether core.getInput or core.getBooleanInput is used in the script: https://www.npmjs.com/package/@actions/core#inputsoutputs

default: "true"
display-workflow-run-url-interval:
description: 'The time to wait (+unit) between two polls to get the URL of the workflow run'
required: false
Expand All @@ -35,22 +35,22 @@ inputs:
wait-for-completion:
description: 'Block until the triggered workflow has finished'
required: false
default: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, why ?

Copy link

@figroc figroc Feb 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this: https://github.com/aurelien-baudet/workflow-dispatch/blob/c2b3c6dfb91343cf66073ac553e613483b046e1c/src/utils.ts#L49

default: "true"
wait-for-completion-timeout:
description: 'Maximum amount of time (+unit) to wait to mark workflow as timed out'
description: 'Maximum amount of time (+unit) to wait to mark workflow as timed out'
required: false
default: 1h
wait-for-completion-interval:
description: 'Time to wait (+unit) between two polls to get run status'
required: false
default: 1m
workflow-logs:
description: 'Indicate what to do with logs of the triggered workflow. `ignore` do not retrieve logs from tiggered workflow. `print` retrieves logs from triggered workflow and print in the workflow that triggered the other workflow.'
description: 'Indicate what to do with logs of the triggered workflow. "ignore" do not retrieve logs from tiggered workflow. "print" retrieves logs from triggered workflow and print in the workflow that triggered the other workflow.'
required: false
default: ignore

runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'

branding:
Expand Down
Loading