Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poset refactor part 2: lattices #295

Merged
merged 39 commits into from
Jan 12, 2024
Merged

Poset refactor part 2: lattices #295

merged 39 commits into from
Jan 12, 2024

Conversation

plt-amy
Copy link
Member

@plt-amy plt-amy commented Nov 30, 2023

Opening a PR so I can use the review interface for these scattered comments.. We can change the base branch once #293 is merged.

Copy link

Rendered preview

Copy link
Member Author

@plt-amy plt-amy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the implicit comments about exploding meet and join semilattices, there's a few other things to iron out IMO

src/Order/Frame.lagda.md Outdated Show resolved Hide resolved
src/Order/Frame.lagda.md Outdated Show resolved Hide resolved
src/Order/Frame.lagda.md Outdated Show resolved Hide resolved
src/Order/Frame.lagda.md Outdated Show resolved Hide resolved
src/Order/Frame.lagda.md Outdated Show resolved Hide resolved
src/Order/Semilattice.lagda.md Outdated Show resolved Hide resolved
src/Order/Semilattice.lagda.md Outdated Show resolved Hide resolved
src/Order/Semilattice.lagda.md Outdated Show resolved Hide resolved
src/Order/Semilattice.lagda.md Outdated Show resolved Hide resolved
src/Cat/Displayed/Doctrine/Frame.lagda.md Outdated Show resolved Hide resolved
@plt-amy plt-amy marked this pull request as draft November 30, 2023 13:03
Base automatically changed from poset-refactor to main November 30, 2023 16:58
@Lavenza
Copy link
Member

Lavenza commented Jan 1, 2024

Pull request preview

@TOTBWF TOTBWF marked this pull request as ready for review January 11, 2024 00:30
@plt-amy plt-amy enabled auto-merge (squash) January 12, 2024 23:08
@plt-amy plt-amy merged commit 5e68237 into main Jan 12, 2024
5 checks passed
@plt-amy plt-amy deleted the lattice-refactor branch January 12, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants