Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search revamp #300

Merged
merged 9 commits into from
Dec 9, 2023
Merged

Search revamp #300

merged 9 commits into from
Dec 9, 2023

Conversation

plt-amy
Copy link
Member

@plt-amy plt-amy commented Dec 2, 2023

Just experimenting with some improvements to the search box

@plt-amy plt-amy added the web For issues/pull requests relating to the 1lab website itself. label Dec 2, 2023
Copy link

github-actions bot commented Dec 2, 2023

Rendered preview

@plt-amy plt-amy force-pushed the aliao/search-revamp branch from 2fabf76 to 1558812 Compare December 8, 2023 18:19
@plt-amy plt-amy requested a review from SquidDev December 8, 2023 18:20
@plt-amy plt-amy marked this pull request as ready for review December 8, 2023 18:21
Copy link
Collaborator

@SquidDev SquidDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is really nice! I had a couple of nitpicks about the buttons, but otherwise this looks good to me!

support/web/js/prompt.tsx Show resolved Hide resolved
support/web/js/theme.tsx Outdated Show resolved Hide resolved
support/web/js/theme.tsx Outdated Show resolved Hide resolved
support/web/js/theme.tsx Outdated Show resolved Hide resolved
@ncfavier
Copy link
Member

ncfavier commented Dec 9, 2023

Where'd the options go? (Serif, hidden code, etc.)

The search results are a bit small, and the module names on the right of the search results are definitely too small.

@plt-amy
Copy link
Member Author

plt-amy commented Dec 9, 2023

Where'd the options go? (Serif, hidden code, etc.)

Copy link
Collaborator

@SquidDev SquidDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thank you!

support/web/js/theme.tsx Show resolved Hide resolved
support/web/js/theme.tsx Show resolved Hide resolved
@plt-amy plt-amy merged commit c2a125a into main Dec 9, 2023
5 checks passed
@plt-amy plt-amy deleted the aliao/search-revamp branch December 9, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web For issues/pull requests relating to the 1lab website itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants