Supports DatePicker element #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roger-tan
commented
Aug 13, 2020
| @@ -67,6 +75,12 @@ final class OtherElementsController: UIViewController { | |||
|
|
|||
| } | |||
|
|
|||
| extension OtherElementsController: UITextFieldDelegate { | |||
| func textFieldShouldReturn(_ textField: UITextField) -> Bool { | |||
| textField.resignFirstResponder() | |||
There was a problem hiding this comment.
Needed to hide the keyboard for the picker after.
roger-tan
commented
Aug 13, 2020
| @@ -166,6 +167,94 @@ final class OtherElementsTests: TABTestCase, SystemPreferencesContext { | |||
| When(I: adjust(otherElementsScreen.picker.wheel(0), to: "World")) | |||
| Then(the: value(of: otherElementsScreen.picker.wheel(0), is: "World")) | |||
| } | |||
|
|
|||
| Scenario("Seeing and interacting with the time picker") { | |||
There was a problem hiding this comment.
Couple tests with differents variations of all date pickers (Date, Time, DateTime and Count Down Time)
zacoid55
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR will add official support of DatePicker element and will resolve issue #55. This will help in future to support the new behaviour of Date Picker in iOS 14. #125
Pre-merge checklist
Before merging any PR, please check the following common things that should be done beforehand. These aren't all always required, so just check the box if it doesn't apply.
TABTestKittarget, notPods-TABTestKit_Exampleetc.pod installto ensure that the latest changes are in the Example project. Without this, Carthage might not see the latest changes.CHANGELOG. For any changes pending a release, add to the Pending section. For releases, move everything pending to the release section.README. Add info for any new features, update existing info for anything that's changed or needs extra info.