Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare number of created files with number of fixtures #1820

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

rpluem-vf
Copy link
Contributor

Ensure that the number of files created by the callback is the same as the number of fixture files to compare with. There have been cases where the callback produced less files and the tests passed without noticing this.

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@48aa035). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1820   +/-   ##
==========================================
  Coverage           ?   35.38%           
==========================================
  Files              ?       94           
  Lines              ?     4595           
  Branches           ?     1133           
==========================================
  Hits               ?     1626           
  Misses             ?     2966           
  Partials           ?        3           
Flag Coverage Δ
sanity 35.38% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Ensure that the number of files created by the callback is the same
as the number of fixture files to compare with. There have been cases
where the callback produced less files and the tests passed without
noticing this.

Signed-off-by: Ruediger Pluem <[email protected]>
@evgeni evgeni force-pushed the compare_with_fixture_numbers branch from 469bc61 to 1efaefd Compare January 29, 2025 07:53
@evgeni evgeni merged commit af10b05 into theforeman:develop Jan 29, 2025
29 checks passed
@rpluem-vf rpluem-vf deleted the compare_with_fixture_numbers branch January 29, 2025 09:35
@rpluem-vf rpluem-vf restored the compare_with_fixture_numbers branch January 29, 2025 09:37
@rpluem-vf rpluem-vf deleted the compare_with_fixture_numbers branch January 29, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants