Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add invalidating registration tokens #3595

Merged
merged 16 commits into from
Feb 3, 2025
Merged

Add invalidating registration tokens #3595

merged 16 commits into from
Feb 3, 2025

Conversation

Lennonka
Copy link
Contributor

@Lennonka Lennonka commented Jan 17, 2025 •
edited
Loading

What changes are you introducing?

Adding 3 procedures for invalidation of the registration JSON Web Tokens (JWTs):

  1. Invalidating one's own JWTs
  2. Invalidating JWTs of one or more other users
  3. Invalidating JWTs of all users at once

No. 1. and 2. available in the GUI, CLI, and API; No 3. only in GUI.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Redmine: 37936, 38138, 38124
RH Jira: SAT-27385 (private)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into: N/A

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

The PR preview for d85ba80 is available at theforeman-foreman-documentation-preview-pr-3595.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@Lennonka Lennonka force-pushed the add-invalidating-reg-tokens branch from f6abc2f to 97ccbee Compare January 17, 2025 21:56
@Lennonka Lennonka added the Waiting for code Requires merge of related code in another repository before it can be merged label Jan 17, 2025
@Lennonka

This comment was marked as outdated.

Sign in to view
@aneta-petrova

This comment was marked as resolved.

Sign in to view
@Lennonka Lennonka marked this pull request as ready for review January 28, 2025 14:23
@Lennonka Lennonka requested a review from girijaasoni January 28, 2025 14:25
@Lennonka Lennonka added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective and removed Waiting for code Requires merge of related code in another repository before it can be merged labels Jan 28, 2025
@Lennonka Lennonka added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective labels Jan 29, 2025
girijaasoni
girijaasoni approved these changes Jan 29, 2025
View reviewed changes
Copy link

@girijaasoni girijaasoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D
Thanks @Lennonka

maximiliankolb
maximiliankolb reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made one minor comment; style-wise LGTM. I did not yet test these workflows myself though.

I like that you add WebUI, CLI, and API procedures. 👍 Lena

guides/common/modules/proc_invalidating-jwts-of-other-users.adoc Outdated Show resolved Hide resolved
@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Jan 30, 2025
@Lennonka Lennonka added the Needs testing Requires functional testing label Jan 31, 2025
@amolpati30
Copy link

I have completed the testing, and everything appears to be functioning as expected. Acknowledgment from QE.

@Lennonka Lennonka added testing done No issues from the functional perspective and removed Needs testing Requires functional testing labels Feb 3, 2025
@Lennonka Lennonka merged commit 126e7e5 into theforeman:master Feb 3, 2025
8 of 9 checks passed
@Lennonka Lennonka deleted the add-invalidating-reg-tokens branch February 3, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girijaasoni girijaasoni girijaasoni approved these changes

@aneta-petrova aneta-petrova aneta-petrova left review comments

@maximiliankolb maximiliankolb maximiliankolb left review comments

Assignees
No one assigned
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective testing done No issues from the functional perspective
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lennonka @aneta-petrova @amolpati30 @maximiliankolb @girijaasoni