Fixes #38171 - Add index on audit to speed up action queries and sorting for latest records #10426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing for latest records
|
Marked draft to work on reproducer steps to replicate the data that actually needs this index. Might close out if deemed unnecessary. |
|
In testing with different types of data, the actual product.last_sync_audit method I was ooking to speed up with this index doesn't actually use this index. I am able to get sql to use this index under very specific queries on different data sets. The original issue I was trying to fix doesn't need the index so will close this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an index to audit table that includes :auditable_type, :auditable_id, :action for quicker querying for particular action on a resource. Also added :created_at to make sorting quicker when we need to check newer records.
The index is specifically helpful for a usecase we have around fetching the latest sync audit record.
Katello/katello#11294