-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #36663 - Add permission to modify LookupValue resource #9803
Conversation
Issues: #36663 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @nofaralfasi, tested with theforeman/foreman_ansible#633. The change in permission_list.rb
is enough.
Some questions inline though:
Thanks, @nofaralfasi, but the test failure is related. |
I'm uncertain about the proper procedure for including these permissions. |
Right, so this is actually my bad. I see two ways to fix that:
|
This is necessary when using gql to allow non-admin users to modify lookup-key values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @nofaralfasi, for bearing with me 🌹 LGTM, works and we're green.
This is necessary when using gql to allow non-admin users to modify lookup-key values.
Required for: