Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use keyword arguments in resource_scope #702

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Mar 21, 2024

This was always a better way, but in Foreman 3.10 the args and kwargs handling was made more explicit.

@adamruzicka
Copy link
Contributor

This didn't seem to help for me, but changing resource_scope did

  def resource_scope(**kwargs)
    @resource_scope ||= scope_for(resource_class, **kwargs)
  end

In Foreman 3.10 the args and kwargs handling was made more explicit.
@ekohl ekohl force-pushed the send-resource_name-as-kwargs branch from cc61569 to bf7026d Compare March 21, 2024 14:27
@ekohl
Copy link
Member Author

ekohl commented Mar 21, 2024

Thanks! That's what I get for doing this in between meetings.

@nofaralfasi nofaralfasi merged commit 214cb25 into theforeman:master Mar 21, 2024
24 of 25 checks passed
@nofaralfasi
Copy link
Contributor

Thanks @ekohl!

@ekohl ekohl deleted the send-resource_name-as-kwargs branch March 21, 2024 17:14
@ekohl ekohl changed the title Send resource as keyword argument in resource_name Use keyword arguments in resource_scope Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants