Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPv6 to the mailer #651

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

stejskalleos
Copy link
Contributor

No description provided.

Copy link
Contributor

@nofaralfasi nofaralfasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stejskalleos Could you please provide steps on how to test this PR? I'm not sure how to navigate to this page.

@stejskalleos
Copy link
Contributor Author

Could you please provide steps on how to test this PR? I'm not sure how to navigate to this page.

AFAIK you can't, email previews have been added in Rails 8.
I was happy that tests were not failing, and that was the end of my "testing". It's a fairly safe and small code change.

@nofaralfasi nofaralfasi merged commit 8635981 into theforeman:develop Jan 21, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants