Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't merge stderr into the output when calling pulp commands #981

Merged
merged 2 commits into from
Feb 12, 2025
Merged

don't merge stderr into the output when calling pulp commands #981

merged 2 commits into from
Feb 12, 2025
+29 −19

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Feb 11, 2025

No description provided.

@evgeni evgeni force-pushed the no-stderr-polution branch from 8aac34a to 915dc36 Compare February 11, 2025 08:20
@evgeni evgeni marked this pull request as draft February 11, 2025 12:37
@evgeni
Copy link
Member Author

evgeni commented Feb 11, 2025

This works, but then spams the console with stderr, let's move to Open3…

@evgeni evgeni marked this pull request as ready for review February 11, 2025 13:10
ekohl
ekohl approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before you know it you'll even pass in commands as arrays to avoid spawning a shell.

@evgeni evgeni merged commit 34609df into master Feb 12, 2025
8 checks passed
@evgeni evgeni deleted the no-stderr-polution branch February 12, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

@ehelms ehelms ehelms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgeni @ekohl @ehelms