Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #324 - RiaH export highlight required and unmapped fields #53

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

guuswilmink
Copy link

@guuswilmink guuswilmink commented Jul 31, 2024

Only changes have been made to the export to Word.

  • Checks to see if target field is nullable. If it is, prepend an asterisk to the field
  • Checks to see if Source Field, Logic, and Comment are empty. If this is the case, the Destination Field is grayed out.
  • Fields may have an asterisk AND be grayed out with this logic.

@guuswilmink guuswilmink requested a review from janblom July 31, 2024 10:46
Copy link

@janblom janblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved under the assumption that the output (Word document) has been visually inspected to match with the intent of the issue and the code.

@guuswilmink
Copy link
Author

Approved under the assumption that the output (Word document) has been visually inspected to match with the intent of the issue and the code.

The Word document has been visually inspected and the outcome is as expected.

@guuswilmink guuswilmink merged commit 21f46e5 into master Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants