Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 313 #54

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Issue 313 #54

merged 3 commits into from
Dec 23, 2024

Conversation

EIjo
Copy link

@EIjo EIjo commented Jul 31, 2024

added support for reading the following date formats:
order formats: "YMD", "DMY, "MDY"
year formats: "yy", "yyyy"
month formats: "M", "MM" (works with single digit month notations)
day formats: "d", "dd" (also works with single digit day notations)
separator formats: "/", ".", "-", " "

Copy link

@janblom janblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a unit test, since it is user facing functionality (mistakes are better caught at build time than by users).

@EIjo EIjo merged commit 04735a7 into master Dec 23, 2024
1 check passed
@EIjo EIjo deleted the issue-313 branch December 23, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants