Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override the search keyboard combination, too #128

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

flying-sheep
Copy link
Collaborator

@flying-sheep flying-sheep commented Jan 12, 2024

also hide the theme popup eagerly, not only when displaying the rtd-sphinx-search one.

@flying-sheep flying-sheep changed the title Fix up the keyboard combination Override the search keyboard combination, too Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87bcc26) 100.00% compared to head (de733a8) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #128   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          368       368           
=========================================
  Hits           368       368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flying-sheep flying-sheep merged commit fa72856 into main Jan 12, 2024
8 checks passed
@flying-sheep flying-sheep deleted the fix-keycomb branch January 12, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant