-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fastMNN corrected feature output #18
base: main
Are you sure you want to change the base?
Conversation
A fastMNN API change causes anndata2ri to break as `LowRankMatrix` can't be converted to python. Converting to `dgCMatrix` fixes that.
Thanks for spotting that! I was wondering why fastMNN suddenly stopped working but didn't know that it was related to a newer version. Will test if the pipeline runs through and get back to you on this |
I think future proofing is better. Thanks for fix @danielStrobl! @mumichae you have power over merging, so if you give it a thumbs up, please merge :). |
I'm still trying to run things, and as it stands, the code doesn't seem tested yet (I got a syntax error). I still need a bit of time though, as I'm having issues with my R environment atm. |
this was missing a bracket, was just quickly transferring my fix without testing from openproblems: danielStrobl/SingleCellOpenProblems@2092d72 |
I just realised that we are most likely looking at different problems here. In Openproblems we are using R 4 and Seuratv4, whereas the pipeline uses R 3.6 and Seuratv3. For some reason, I am not getting any errors with fastMNN anymore after recreating the R environment. Sooner or later, we should move to R 4 and only keep the 3.6 and respective dependencies for reproducibility reasons. Once that is underway, this fix will be useful, but it will break pipelines running with older versions. |
Yes, ideally R 4 as soon as possible. |
Just FYI R 4.1 is the current version and R 4.2 comes out in a month. I would probably just skip ahead to whatever the current version is when you get around to this. |
A fastMNN API change causes anndata2ri to break for newer batchelor versions as
LowRankMatrix
can't be converted to python. Converting todgCMatrix
fixes that.Not sure if we want to lock to an older batchelor version or do this fix here.