Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to VF for GF #28

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Upgraded to VF for GF #28

wants to merge 12 commits into from

Conversation

bghryct
Copy link

@bghryct bghryct commented Feb 5, 2020

upgraded and expanded for pull request to google fonts

@alerque
Copy link
Member

alerque commented Mar 26, 2020

Just to let you know, @micahbrich and I were poking around fonts yesterday and bumped into this. We do plan to integrate it! Sorry it's taken so long to get some attention. I'm working on some toolchain pieces and on cleaning up the git repositories for all the League fonts. This is actively on our list.

@bghryct
Copy link
Author

bghryct commented Mar 26, 2020

Thanks! Happy to talk fonts sometime. lomt really inspired me to work on fonts when I was a student.

@alerque
Copy link
Member

alerque commented Mar 26, 2020

@bghryct I'm a very long time user of League fonts myself but only recently got involved in contributing. I'm not a designer, doing more programming and typesetting work, but feel free to drop into the Gitter room we started the other day.

@alerque alerque mentioned this pull request Apr 9, 2020
@alerque
Copy link
Member

alerque commented Nov 2, 2020

@sursly Did you have an eye on this while working on the variable update in your fork?

@alerque alerque marked this pull request as draft November 2, 2020 11:28
@sursly
Copy link

sursly commented Nov 2, 2020

@alerque nope, I've never seen this

@davelab6
Copy link
Contributor

davelab6 commented Aug 5, 2021

@alerque this PR has now diverged from this repo's main branch. At Google Fonts we had got @bghryct 's work onto our sandbox, but we'd now like to sync the 2-3 threads of work (@bghryct GF- and VF- ication, @alerque 's build work, and @sursly 's design work) and publish that. How should we proceed?

@alerque alerque self-assigned this Aug 6, 2021
@alerque
Copy link
Member

alerque commented Aug 6, 2021

I'll have another look based on the above info, but from memory when I first reviewed the differences there were two entirely parallel sets of design work and somebody would need to decide which way to go. I'll skim over the status to see where each is at technically, then figure out what design bits should be reviewed.

@RosaWagner
Copy link

Does anyone want to take a decision, or I can go with whatever is more practical on our end and PR a solution?

@sursly
Copy link

sursly commented Oct 29, 2021

@RosaWagner again, my work on it from last year might seem familiar to you. I think it needs more love than League Spartan, but it should be in a good place to prep for GF.

@RosaWagner
Copy link

After analysing all the sources: Tyler's version have corrected curves and expanded glyphset to vietnamese BUT italic and Italic condensed are not compatible. Also Caleb's version (and Mirko's edits) has expanded masters.

@sursly
Copy link

sursly commented Oct 29, 2021

The italics I made (what, 7 years ago or something?) are pretty bad @RosaWagner, Oblique, and not very good at that. Not worth keeping, in my opinion.

@RosaWagner
Copy link

Okay, so after analysing the sources deeper and talk with Dave, we decided to onboard Tyler's version as a first step even if the designspace is reduced. It has less masters but wider language coverage, corrected outlines and improved interpolation. So we should have less bug reports with this one. @sursly you will receive a PR from Emma shortly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants