-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded to VF for GF #28
base: master
Are you sure you want to change the base?
Conversation
Just to let you know, @micahbrich and I were poking around fonts yesterday and bumped into this. We do plan to integrate it! Sorry it's taken so long to get some attention. I'm working on some toolchain pieces and on cleaning up the git repositories for all the League fonts. This is actively on our list. |
Thanks! Happy to talk fonts sometime. lomt really inspired me to work on fonts when I was a student. |
@bghryct I'm a very long time user of League fonts myself but only recently got involved in contributing. I'm not a designer, doing more programming and typesetting work, but feel free to drop into the Gitter room we started the other day. |
@sursly Did you have an eye on this while working on the variable update in your fork? |
@alerque nope, I've never seen this |
I'll have another look based on the above info, but from memory when I first reviewed the differences there were two entirely parallel sets of design work and somebody would need to decide which way to go. I'll skim over the status to see where each is at technically, then figure out what design bits should be reviewed. |
Does anyone want to take a decision, or I can go with whatever is more practical on our end and PR a solution? |
@RosaWagner again, my work on it from last year might seem familiar to you. I think it needs more love than League Spartan, but it should be in a good place to prep for GF. |
After analysing all the sources: Tyler's version have corrected curves and expanded glyphset to vietnamese BUT italic and Italic condensed are not compatible. Also Caleb's version (and Mirko's edits) has expanded masters. |
The italics I made (what, 7 years ago or something?) are pretty bad @RosaWagner, Oblique, and not very good at that. Not worth keeping, in my opinion. |
Okay, so after analysing the sources deeper and talk with Dave, we decided to onboard Tyler's version as a first step even if the designspace is reduced. It has less masters but wider language coverage, corrected outlines and improved interpolation. So we should have less bug reports with this one. @sursly you will receive a PR from Emma shortly :) |
upgraded and expanded for pull request to google fonts