Adjusted baseline upwards #21
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so cap height is vertically aligned in the middle, when rendered in the browser. ascender to descender ratio should is 18/7
|
Thanks for taking the time to contribute! I'll be reviewing this and getting the original designer to check it as well. In the mean time we have a number of pending changes to the way the repository is organized that need to be merged before this. I'm converting the PR to a draft for now just so it doesn't accidentally get merged before the other changes. As soon as the others go through (and pending designer approval) I'll handle the merge issues and update this for inclusion. |
|
Hello! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted baseline upwards by changing the the ratio between the Ascender and Descender.
I did this because the ready built fonts had baselines that rendered too low in multiple browsers on Windows, causing inline vertical alignment issues and descenders being clipped.
The fonts used on the league website (rev 2.0) did not have these issues and rendered perfectly in the middle of the line-height.
Upon comparison of the metrics, it seems that rev2.0 has an ascender to descender ratio of 18:7. Applied this ratio and seems to do the trick. Tested ok in browsers and Adobe suite on Windows.