Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italics #22

Closed
wants to merge 20 commits into from
Closed

Italics #22

wants to merge 20 commits into from

Conversation

cssobral2013
Copy link

This PR includes Italics, its TTF binaries, and its source.

@alerque
Copy link
Member

alerque commented Aug 17, 2020

Thanks for taking the time to contribute @cssobral2013!

Can you please remove the built TTF files from this? Per the other‌ PR's in progress on this font everything is going to be autogenerated in CI jobs and posted as artifacts & attached to releases. The binary generated fonts won't be in the repository itself.

It will be a lot easier to review this PR if it only includes the relevant changes to the source.

@alerque alerque marked this pull request as draft August 17, 2020 06:32
@alerque
Copy link
Member

alerque commented Aug 17, 2020

P.S. If you're unsure how to rebase this branch to do that just comment and I'd be happy to do it, it's a pretty easy step with the right tools but definitely more advanced Git foo ;-)

Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to remove all the generated *.ttf files.

@cssobral2013
Copy link
Author

@alerque - Completed!

@alerque alerque mentioned this pull request Aug 22, 2020
@alerque
Copy link
Member

alerque commented Aug 31, 2020

Quoted form parallel PR:

Thanks @cssobral2013. I'm in much the same boat being on Linux. I've tagged both your original PR and this on as help wanted and would encourage anybody who is interested in taking this on to drop a comment and I'd be glad to help work through the process. But we do need somebody with Glyphs and a working knowledge of it.

Eventually Fontship should facilitate the process of contributing to fonts using any editor by providing conversion between source formats, but that bit is under-developed right now.

Additionally this PR should be building the Italic font as ready to use binary artifacts that anybody could test, but there is a syntax problem with the Glyphs file. Until that is worked out we can't even really preview how this would fit in.

Again to anybody interested in helping, please drop a line here and I'll help you get rolling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants