Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a packge.json so that it can be installed with npm #8

Closed
wants to merge 1 commit into from

Conversation

mintbridge
Copy link

Hi,

First of all, thanks for the font, its really nice. I've added a npm package.json file so that it can be installed using npm (and then put into an asset pipeline) hope its useful? It doesn't mean that you need to publish it on npm but it might be worth it.

thanks,
Paul

alerque pushed a commit that referenced this pull request Aug 25, 2020
@alerque
Copy link
Member

alerque commented Aug 27, 2020

Thanks for taking the time to contribute. I'm sorry this didn't get evaluated sooner — but before my time!

I'm pretty sure this is obsolete now. I've never used NPM to fetch fonts anyway, but it looks like this would only work with binary font artifacts in the Git repo—which is no longer the case. The font would either need to be built after cloning or just use the packages attached to releases.

I'm happy to help facilitate any workflow that would be of broad use: for example Fontship could be setup to include a manifest file like this in release packages. If you think that's a useful direction please open an issue over there.

@alerque alerque closed this Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants