Add "Legacy templates" section to NIC documentation #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for theos-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
L1ghtmann
approved these changes
Feb 2, 2025
There was a problem hiding this comment.
Looks good to me - just have a couple comments, see below. Thanks for doing all of this!
Only comments are:
the _modern suffixed app templates don't match the ones we ship;realizing this is part of Fixed non notched window size on notched devices when sideloading an app templates#31- it may make more sense to rename the legacy versions with a suffix and keep the "modern" versions as generic names
|
You're welcome! For 2: For context, I touched on this briefly in theos/templates#31 (comment) and in more detail in https://discord.com/channels/811490080278839327/811494949849661490/1332463265946533928 My current perspective is: in case anyone was using the I'm not too attached to this perspective though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Update the NIC documentation to match changes in https://github.com/theos/templates
Specifically, these docs are intended to match what NIC should look like after theos/templates#31 and theos/templates#36 are merged.
Additionally, (considered part of theos/templates#36) this PR adds a section for the new https://github.com/theos/templates-legacy module.
Does this close any currently open issues?
No
Any relevant logs, error output, etc?
No
Any other comments?
We expect theos/templates#31, theos/templates#36, and this PR to all be merged around the same time.