copier: add support for windows sample type setting #8456
Conversation
|
@dnikodem can you help to check this PR with windows ? thanks |
RanderWang
force-pushed
the
windows_msb_support
branch
from
f8e8c78 to
497d9fd
Compare
There was a problem hiding this comment.
@RanderWang does this mean we need to do extra or differet conversions for windows in the copier ? i.e. no net gain in MCPS.
As you know, Windows has a different layout of 24/32 compared to SOF implementation. Windows always set MSB_TYPE all the modules while Linux topology set correct type for each module, so we need to adjust format to choose the correct conversion for this case. It will not affect performance since the conversion function is the same as Linux but the sample type is not fit for SOF. |
Thank you for clarifying - just a different conversion in FW with no MCPS impact. Lets wait on @dnikodem review now. |
RanderWang
force-pushed
the
windows_msb_support
branch
from
497d9fd to
55bfb54
Compare
|
Thanks for @dnikodem's hard work on validation on windows platforms. Pass the test, so it is ready for review. |
RanderWang
changed the title
Windows driver always set sample type of MSB for 24/32 format but SOF FW supports 24/32 LSB type for non-copier modules. So FW will convert the input MSB 24/32 to LSB 24/32 and process it and convert it back to MSB 24/32 when exiting gtw. Signed-off-by: Rander Wang <[email protected]> Signed-off-by: Damian Nikodem <[email protected]>
RanderWang
force-pushed
the
windows_msb_support
branch
from
55bfb54 to
ce5c8d9
Compare
|
Seeing some cluster failures with nocodec, lets be sure. |
|
SOFCI TEST |
|
Multicore failure. It will be fixed by #8515 |
Now merged - will rerun the CI. |
|
SOFCI TEST |
1 similar comment
|
SOFCI TEST |
|
ignore sof-ci/jenkins/pr-device-test/main-cavs2.5 which is a old test item for old PR and not used by latest PR in Github. |
| default: | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
can we combine two switch case to one and move two if() inside case?
There was a problem hiding this comment.
lets take that as an optimization for followup in another PR.
| default: | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
lets take that as an optimization for followup in another PR.
Windows driver always set sample type of MSB for 24/32 format but SOF FW supports 24/32 LSB type for non-copier modules. So FW will convert the input MSB 24/32 to LSB 24/32 and process it and convert it back to MSB 24/32 when exiting gtw.