Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: zephyr_ll: update zephyr_ll_task_insert_unlocked comments #8507

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Nov 21, 2023

Clarify the inline comment in zephyr_ll_task_insert_unlocked() explaining the task priority semantics. The old text is not clear on what is "high priority". Make it explicit that 0 is the highest priority and that the tasks are executed in order of task priority.

@kv2019i kv2019i force-pushed the 202311-zephyr-ll-doc-update branch from ff21af3 to 18ba7a3 Compare November 21, 2023 16:10
@kv2019i
Copy link
Collaborator Author

kv2019i commented Nov 21, 2023

V2: tiny rewording of the comment

  • based on @ujfalusi 's feedback, fine-tuned the wording -> use "the largest priority value" to discuss the absolute values and mathematical MAX() seen, and use "the highest priority" when talking about the semantics (e.g. that smaller values have higher priority)

Clarify the inline comment in zephyr_ll_task_insert_unlocked()
explaining the task priority semantics. The old text is not clear on
what is "high priority". Make it explicit that 0 is the highest priority
and that the tasks are executed in order of task priority.

Signed-off-by: Kai Vehmanen <[email protected]>
@kv2019i kv2019i force-pushed the 202311-zephyr-ll-doc-update branch from 18ba7a3 to 2bc7073 Compare November 21, 2023 18:26
@kv2019i
Copy link
Collaborator Author

kv2019i commented Nov 21, 2023

V3 uploaded:

  • text still too complicated, simplified the comment further

@dbaluta dbaluta merged commit ee80da7 into thesofproject:main Nov 22, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants