DP: bugix - lists initialization was done too late #8508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in case module prepare fails, dp_queue lists were left uninitialized. It may lead to crash if module reset was performed later Signed-off-by: Marcin Szkudlinski <[email protected]>
marcinszkudlinski
requested review from
ranj063 and
jxstelter
as code owners
jxstelter
approved these changes
Nov 21, 2023
lgirdwood
approved these changes
Nov 21, 2023
kv2019i
approved these changes
Nov 21, 2023
| @@ -168,6 +168,9 @@ static int module_adapter_dp_queue_prepare(struct comp_dev *dev) | |||
| * first, set all parameters by calling "module prepare" with pointers to | |||
There was a problem hiding this comment.
"bugix" ? Also "module_adapter: " would be a better prefix. But not showstoppers, change itself looks good and git commit is understandable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case module prepare fails, dp_queue lists were left uninitialized.
It may lead to crash if module reset was performed later