topology2: pipeline: document pipeline.priority attribute #8509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btian1
reviewed
Nov 22, 2023
| @@ -57,7 +57,7 @@ Class.Widget."pipeline" { | |||
| } | |||
| } | |||
|
|
|||
| # pipeline priority | |||
| # pipeline priority (0 = highest priority) | |||
There was a problem hiding this comment.
can we add more? like priority range: 0 ~ ?
There was a problem hiding this comment.
ok, yeah, also useful to add "lowest = 7" iirc.
There was a problem hiding this comment.
@btian1 @lgirdwood I agree but this is complex. 0 = highest applies to all implementations, but fine details of other semantics are still a bit unclear to me, including what is the lowest. in IPC4 this is 7, but we don't have such for IPC3. but fair enough, let me investigate more to come up with the documentation.
lgirdwood
reviewed
Nov 24, 2023
| @@ -57,7 +57,7 @@ Class.Widget."pipeline" { | |||
| } | |||
| } | |||
|
|
|||
| # pipeline priority | |||
| # pipeline priority (0 = highest priority) | |||
There was a problem hiding this comment.
ok, yeah, also useful to add "lowest = 7" iirc.
RanderWang
approved these changes
Nov 27, 2023
Add constraints on valid pipeline priority values and document the semantics so that 0 is considered the highest priority and such pipeline should be run first. The range matches definitions in include/ipc4/pipeline.h and SOF_IPC4_MAX_PIPELINE_PRIORITY. Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
force-pushed
the
202311-tplg-pipe-priority-doc
branch
from
22f7dbe to
179bbd5
Compare
|
V2:
|
bardliao
approved these changes
Apr 5, 2024
|
SOFCI TEST |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a note that priority 0 is the highest priority and indicates pipeline that should be run first. This matches with the SOF scheduler implementation.