xtensa-build-zephyr.py: fail on --deployable-build + older options #8739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better late than never... zero functional change. Signed-off-by: Marc Herbert <[email protected]>
From experience, no one scrolls up and looks at warnings that are not in the current screen. Signed-off-by: Marc Herbert <[email protected]>
marc-hb
changed the title
marc-hb
requested review from
ujfalusi,
plbossart,
mengdonglin,
keqiaozhang,
kv2019i and
aiChaoSONG
ujfalusi
approved these changes
Jan 15, 2024
kv2019i
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 commits. Main one:
xtensa-build-zephyr.py: fail on --deployable-build + older options
From experience, no one scrolls up and looks at warnings that are not in the current screen.
There's no reason to use both the old options and the brand new one at the same time, it would be a huge mistake.