[CI ONLY] Test #8878
Draft
[CI ONLY] Test #8878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softwarecki
force-pushed
the
lib-test
branch
11 times, most recently
from
d7704c3 to
3bbe5ec
Compare
softwarecki
force-pushed
the
lib-test
branch
4 times, most recently
from
70c22c0 to
1fe992f
Compare
softwarecki
force-pushed
the
lib-test
branch
13 times, most recently
from
d422085 to
d37d689
Compare
softwarecki
force-pushed
the
lib-test
branch
2 times, most recently
from
a25b144 to
f1855e2
Compare
softwarecki
force-pushed
the
lib-test
branch
4 times, most recently
from
1aee3e5 to
d9a8a78
Compare
softwarecki
force-pushed
the
lib-test
branch
3 times, most recently
from
96fddef to
b0d9601
Compare
softwarecki
force-pushed
the
lib-test
branch
2 times, most recently
from
92bcbef to
9cda98d
Compare
|
SOFCI TEST |
softwarecki
force-pushed
the
lib-test
branch
2 times, most recently
from
79977c6 to
6e98c8a
Compare
softwarecki
force-pushed
the
lib-test
branch
5 times, most recently
from
72b3710 to
8f195f2
Compare
Change the type of the UUID parameter in the ipc4_get_drv function to avoid unnecessary typecasting. There are currently two ways to store UUIDs in SOF: as a byte array or as a sof_uuid structure. The ipc4_get_drv function compares UUIDs using the memcmp function, so it is not dependent on the type of the argument passed. This change is intended to prepare the code for standardizing the UUID format across the project. Signed-off-by: Adrian Warecki <[email protected]>
Change the uuid parameter type to void * in the parse_uuid function to make it independent of the UUID type and avoid unnecessary type casting. This change is intended to prepare the code for standardizing the UUID format across the project. Signed-off-by: Adrian Warecki <[email protected]>
Some identifiers are taken from the module manifest. Since the module manifest structure (sof_man_module) is marked as packed, the pointer to the sof_uuid structure may not be properly aligned. Mark the sof_uuid structure as packed to avoid possible problems with accessing fields of this structure from unaligned addresses. Signed-off-by: Adrian Warecki <[email protected]>
Separate the SOF_REG_UUID macro to allow use it to initialize variables with a value from the register. Signed-off-by: Adrian Warecki <[email protected]>
Remove the reference to the first element of the array storing the uuid to prepare the code for changing the uuid type from an array to a struct. Signed-off-by: Adrian Warecki <[email protected]>
Add a & symbol for getting the address of a variable to prepare the code for changing the uuid type from an array to a structure. Signed-off-by: Adrian Warecki <[email protected]>
Change the UUID storage type in the module manifest to a sof-compatible structure to enable retrieval of the UUIDs from the registry. Obtain the UUIDs of loadable llext modules from the uuid-registry. Signed-off-by: Adrian Warecki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNR