Audio: Tune: Cleanup for the setup scripts for audio processing components #9749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singalsu
requested review from
a team,
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
singalsu
commented
Dec 20, 2024
lgirdwood
approved these changes
Dec 20, 2024
kv2019i
reviewed
Dec 27, 2024
| "cd tools/tune/aria; octave sof_aria_blobs.m"); | ||
| sof_tplg2_write(tplg2_fn, blob8, "aria_config", ... | ||
| "Exported with script sof_aria_blobs.m" , ... | ||
| "cd tools/tune/aria; octave sof_aria_blobs.m"); |
There was a problem hiding this comment.
Hmm, check_create_dir() is dropped from this one place, but not all? I guess this call on old L23 was unnecessary and so can be removed? I'd prefer a rename (that touches so many places) to be in its own commit and put any small refactoring changes to separate commits.
There was a problem hiding this comment.
I don't remember exactly why so, but I'll try to split this. I try to keep every commit functional to not break bisect. There was probably some issue with those path create helpers.
There was a problem hiding this comment.
It was a lazy delete, there was no directory check in sof_check_create_dir(). It's now added to 2nd commit as well as these cleanups.
singalsu
force-pushed
the
sof_tune_common_cleanup
branch
from
e676b9a to
b42041e
Compare
This patch renames the common helper functions with sof_prefix. The other scripts are updated to use the updated names. There is no change in functionality. Signed-off-by: Seppo Ingalsuo <[email protected]>
This patch adds to sof_tplg_write() and sof_tplg2_write() helper functions create of file directory path if such is missing. Other format blob export functions already have the same check. The duplicated checks are removed from component specific blobs create functions. Signed-off-by: Seppo Ingalsuo <[email protected]>
This patch updates the equalizer tools to use the common helper functions instead of the originally developed similar functions for equalizers. The old duplicated functions are deleted. Signed-off-by: Seppo Ingalsuo <[email protected]>
The common functions version of topology blob export supports the howto comment. These changes add the instructions text to all equalizer blobs. Signed-off-by: Seppo Ingalsuo <[email protected]>
To align the suffix for binary blob files for UCM cset-tlv and sof-ctl the file naming is changed from .blob to .bin. The .bin is better associated for binary files. Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
force-pushed
the
sof_tune_common_cleanup
branch
from
b42041e to
e26b072
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up various blobs export scripts.