lib_manager: clean up logging #9767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyakh
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
kv2019i
reviewed
Jan 8, 2025
src/library_manager/lib_manager.c
Outdated
| @@ -116,7 +116,7 @@ static int lib_manager_auth_proc(const void *buffer_data, | |||
| ret = auth_api_result(&ext_lib->auth_ctx); | |||
|
|
|||
| if (ret != AUTH_IMAGE_TRUSTED) { | |||
| tr_err(&lib_manager_tr, "lib_manager_auth_proc() Untrasted library!"); | |||
| tr_err(&lib_manager_tr, "Untrasted library!"); | |||
With Zephyr function names are included in log messages, no need to supply them in the format string. Also reduce verbosity of lib_manager_module_create() - it's called every time a loadable module is instantiated, no need to log this fact. Signed-off-by: Guennadi Liakhovetski <[email protected]>
lgirdwood
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Zephyr function names are included in log messages, no need to supply them in the format string. Also reduce verbosity of lib_manager_module_create() - it's called every time a loadable module is instantiated, no need to log this fact.