Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module type #365

Merged
merged 7 commits into from
Mar 19, 2024
Merged

Module type #365

merged 7 commits into from
Mar 19, 2024

Conversation

joente
Copy link
Member

@joente joente commented Mar 19, 2024

Description

  • Restrict future arguments for then() or else() to objects without an Id.
  • Module as type, no longer the workaround of exposing modules as futures.
  • Added the is_module() function.
  • Support ThingsDB code in exposed module functions.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (restriction and module type has changed)
  • This change requires a documentation update

How Has This Been Tested?

  • Test collection functions
  • Test futures

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@joente joente self-assigned this Mar 19, 2024
@joente joente merged commit 1a32b54 into main Mar 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joente joente

Labels
breaking bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joente