Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ARM64 container #377

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Add support for ARM64 container #377

merged 4 commits into from
Apr 23, 2024

Conversation

rickmoonex
Copy link
Contributor

@rickmoonex rickmoonex commented Apr 23, 2024

Description

Updated the code build and add a Dockerfile to add support for ARM64 architecture machines.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Build and ran the arm64 container. Builds without issues and runs as expected.

Test Configuration:

  • MacOS 14.3.1
  • Docker 25.0.3, build 4debf41

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

Copy link
Member

@joente joente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. It looks good! I'll merge the PR into the dev branch for more testing and an alpha release.

(also thanks for addressing the spaces in the YAML files)

@joente joente changed the base branch from main to dev April 23, 2024 12:21
@joente joente merged commit a04cef5 into thingsdb:dev Apr 23, 2024
1 check passed
joente added a commit that referenced this pull request Apr 23, 2024
* typo in comment

* Upd index

* cosmetic

* padding and no underscore

* Add support for ARM64 container (#377)

* fix: add check for `aarch64`

* chore: disable checking type limit

This due to an error that occurs on aarch64 builds

* feat: add dockerfile for arm64 build

* feat: add arm64 build to deploy pipeline

* alpha0 version (1.6.1)

---------

Co-authored-by: Rick Moonen <[email protected]>
joente added a commit that referenced this pull request May 2, 2024
…I instruction set. (#380)

* cosmetic

* padding and no underscore

* Add support for ARM64 container (#377)

* fix: add check for `aarch64`

* chore: disable checking type limit

This due to an error that occurs on aarch64 builds

* feat: add dockerfile for arm64 build

* feat: add arm64 build to deploy pipeline

* alpha0 version (1.6.1)


---------

Co-authored-by: Rick Moonen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants