Feature/fix issue417 #422
Open
Feature/fix issue417 #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g outside the array.
…but might as well be safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my simple attempt at fixing Issue #417. The problem is that we're reaching line 278 of
conditions/mummer.cwithSLICE_STARTER(si) == no_sideand there's no corresponding entry inmummer_measure_length. This fix adds such an entry and sets it toNULL, which is the only sensible default for an unspecified function pointer. This clears the undefined behavior (and ensures we skip lines 280-303) and is plausibly correct, but there remains an alternative. Perhaps in fact the bug is higher up in whatever is causing us to reach that pointSLICE_STARTER(si) == no_side. If so then that would still need to be fixed, but even if that's the case adding this entry tomummer_measure_lengthcan't hurt anything.