-
Notifications
You must be signed in to change notification settings - Fork 55
Refactor #35
base: master
Are you sure you want to change the base?
Refactor #35
Conversation
Currently, this class implements the shortcut for [en|de]cryption methods. In the future, this class would be used for the oauth-php interface implementations.
Easier to test/list clients records
Signed-off-by: Rachman Chavik <[email protected]>
I've just implemented a complete rewrite using a newer library that actually looks a lot like this - I will use your ideas here to package it as a plugin and push it up over the next few weeks - would be a nice v2.0 |
Awesome. Definitely looking forward for the your new version. Sorry about the inactivity on this repo. The project using this plugin has been put into the back burner and time is usually a problem (like everyone else). |
Absolutely no worries, there's no expectation for you to maintain it :) Will get it done over coming weeks, will also try to start adding some tests!! |
@thomseddon When you say you are doing a rewrite does that mean you have a new oauth2-php library and will the implicit grant type be available? |
Yes it uses bshaffer's: https://github.com/bshaffer/oauth2-server-php and it does seem to have implicit grant. I have started this but getting the required functionality into an authenticate object has proved a little tricky, I'm getting there though. |
@thomseddon Ah cool. Not to put any pressure on you as I think it's awesome you have taken the time to make this plugin, but do you have any indications for when it might be ready, just so I can scope out the project time scales roughly. Thanks pal :) |
It will probably take a few more weeks to get it out, sorry if it doesn't sit well with your schedules |
Few weeks will probably be fine :) However, I'm still confused about how the implicit grant type will offer the continuous logged in state that I'm achieving by using refreshTokens on the client side. Any chance you can offer some clarity on this: https://github.com/thomseddon/cakephp-oauth-server/issues/40 Thanks pal. |
How's this going? Any chance of a release soon? Thanks |
Hi thomseddon. How's the refactoring going? You had chance to launch a beta? Cheers |
Ich bin bis 02.06.2014 ausser Haus. Die eMails werden nicht automatisch weitergeleitet. Mit freundlichen Grüßen I am out of office until 02nd of june 2014. |
Hi thomseddon, Are you working on this? Grtz Reijer |
This changeset refactor out the OAuth interface implementations into
OAuthUtility
. Leaving the component backward compatible (code-wise).The next commit implements OAuthAuthenticate class that uses the interface in OAuthUtility. This class can be used to authenticate user by the access_token:
Note: This class only authenticates requests. Authorization should be handled separately, either by Acl or Controller:isAuthorize()
Since this depends on the previous two PRs, actual diff is: 1913409...ac4a4ca