Skip to content
This repository has been archived by the owner on Nov 9, 2018. It is now read-only.

Refactor #35

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Refactor #35

wants to merge 9 commits into from

Conversation

rchavik
Copy link
Collaborator

@rchavik rchavik commented Aug 21, 2013

This changeset refactor out the OAuth interface implementations into OAuthUtility. Leaving the component backward compatible (code-wise).

The next commit implements OAuthAuthenticate class that uses the interface in OAuthUtility. This class can be used to authenticate user by the access_token:

$this->Auth->authorize = array(
   'Form', // standard cakephp login forms
   'OAuth.OAuth', // by access_token in requests (Authorization header or access_token query string)
); 

Note: This class only authenticates requests. Authorization should be handled separately, either by Acl or Controller:isAuthorize()

Since this depends on the previous two PRs, actual diff is: 1913409...ac4a4ca

@thomseddon
Copy link
Owner

I've just implemented a complete rewrite using a newer library that actually looks a lot like this - I will use your ideas here to package it as a plugin and push it up over the next few weeks - would be a nice v2.0

@rchavik
Copy link
Collaborator Author

rchavik commented Jan 9, 2014

Awesome. Definitely looking forward for the your new version.

Sorry about the inactivity on this repo. The project using this plugin has been put into the back burner and time is usually a problem (like everyone else).

@thomseddon
Copy link
Owner

Absolutely no worries, there's no expectation for you to maintain it :)

Will get it done over coming weeks, will also try to start adding some tests!!

@iamdriz
Copy link

iamdriz commented Feb 9, 2014

@thomseddon When you say you are doing a rewrite does that mean you have a new oauth2-php library and will the implicit grant type be available?

@thomseddon
Copy link
Owner

Yes it uses bshaffer's: https://github.com/bshaffer/oauth2-server-php and it does seem to have implicit grant.

I have started this but getting the required functionality into an authenticate object has proved a little tricky, I'm getting there though.

@iamdriz
Copy link

iamdriz commented Feb 10, 2014

@thomseddon Ah cool. Not to put any pressure on you as I think it's awesome you have taken the time to make this plugin, but do you have any indications for when it might be ready, just so I can scope out the project time scales roughly. Thanks pal :)

@thomseddon
Copy link
Owner

It will probably take a few more weeks to get it out, sorry if it doesn't sit well with your schedules

@iamdriz
Copy link

iamdriz commented Feb 10, 2014

Few weeks will probably be fine :) However, I'm still confused about how the implicit grant type will offer the continuous logged in state that I'm achieving by using refreshTokens on the client side. Any chance you can offer some clarity on this: https://github.com/thomseddon/cakephp-oauth-server/issues/40 Thanks pal.

@iamdriz
Copy link

iamdriz commented Apr 18, 2014

How's this going? Any chance of a release soon? Thanks

@iamdriz
Copy link

iamdriz commented Jun 1, 2014

Hi thomseddon. How's the refactoring going? You had chance to launch a beta? Cheers

@grizzly
Copy link

grizzly commented Jun 1, 2014

Ich bin bis 02.06.2014 ausser Haus.

Die eMails werden nicht automatisch weitergeleitet.

Mit freundlichen Grüßen
Stefan Mayr

I am out of office until 02nd of june 2014.

@reijervano
Copy link

Hi thomseddon,

Are you working on this?

Grtz Reijer

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants