Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Gold Miner distributors #42

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

MatheusRich
Copy link
Contributor

Distribution is the last step after mining and smithing gold. It's the final step, where we deliver something useful to the world. We do that using distributor objects.

Distributors are objects that respond to #distribute and perform some kind of "delivery". For now, we have the TerminalDistributor which prints the generated blog post to the terminal. I'm planning to add a GitHub distributor that will open a pull request for the generated blog post.

Unlike Smiths, that take GoldContainers with GoldNuggets, I haven't found a good abstraction for what Distributors accept. We only produce blog posts, so I'm using that for now. It's not generic, but I'll wait until we have more examples of distributors to find a good abstraction.

Distribution is the last step after mining and smithing gold. It's the final step,
where we deliver something useful to the world. We do that using distributor
objects.

Distributors are objects that respond to `#distribute` and perform some
kind of "delivery". For now, we have the `TerminalDistributor` which prints the
generated blog post to the terminal. I'm [planning to add] a GitHub distributor
that will open a pull request for the generated blog post.

Unlike Smiths, that take GoldContainers with GoldNuggets, I haven't found
a good abstraction for what Distributors accept. We only produce blog posts,
so I'm using that for now. It's not generic, but I'll wait until we have more
examples of distributors to find a good abstraction.

[planning to add]: #1
@MatheusRich MatheusRich requested a review from elias19r October 20, 2023 19:55
@MatheusRich MatheusRich merged commit fd30c36 into main Oct 20, 2023
3 checks passed
@MatheusRich MatheusRich deleted the mr/introduce-distributors branch October 20, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants