Rewrite GoldMiner main entrypoint
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatheusRich
commented
Oct 23, 2023
|
|
||
| puts "[DEBUG] #{msg}" | ||
| def prepare |
There was a problem hiding this comment.
A sub-goal of mine with this rewrite was to remove logic from this file. While I think the current approach is much cleaner than before, this method is still something I want to improve later.
MatheusRich
commented
Oct 23, 2023
Comment on lines
+17
to
+20
| .bind { GoldMiner::Slack::Client.build(api_token: ENV["SLACK_API_TOKEN"]) } | ||
| .fmap { |slack_client| | ||
| GoldMiner::SlackExplorer.new(slack_client, GoldMiner::AuthorConfig.default) | ||
| } |
There was a problem hiding this comment.
Maybe we could have a SlackExplorer.build method that tries to by the client first and uses default values so we could rewrite this in a single line?
Suggested change
| .bind { GoldMiner::Slack::Client.build(api_token: ENV["SLACK_API_TOKEN"]) } | |
| .fmap { |slack_client| | |
| GoldMiner::SlackExplorer.new(slack_client, GoldMiner::AuthorConfig.default) | |
| } | |
| .bind { GoldMiner::SlackExplorer.build } |
Previously, the `GoldMiner` module (now a class) had methods for each part of the mining process: exploration, smithing, and distribution. The orchestration of when and how these methods were called was done in the `exe/gold_miner` script. This wasn't ideal since there's no way to guarantee the order in which the methods are called, and a script is arguably not the best place to put this logic. Furthermore, that arrangement wasn't flexible, as there was no way to specify different explorers, smiths, or distributors. This commit rewrites the `GoldMiner` class to have an `initialize` method that receives the explorer, smith, and distributor as arguments. It also adds a `#mine` method that orchestrates the mining process.
MatheusRich
force-pushed
the
mr/gold-miner-rewriting
branch
from
beba851 to
a137d94
Compare
MatheusRich
commented
Oct 27, 2023
Comment on lines
+28
to
+30
| explorer: slack_explorer, | ||
| smith: GoldMiner::BlogPostSmith.new, | ||
| distributor: GoldMiner::TerminalDistributor.new |
There was a problem hiding this comment.
All the previous refactor PRs had this in mind. Now that we can swap parts of the process and produce new behaviors.
When we have a proper CLI, this will be handy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
GoldMinermodule (now a class) had methods for each part of the mining process: exploration, smithing, and distribution.The orchestration of when and how these methods were called was done in the
exe/gold_minerscript. This wasn't ideal since there's no way to guarantee the order in which the methods are called, and a script is arguably not the best place to put this logic. Furthermore, that arrangement wasn't flexible, as there was no way to specify different explorers, smiths, or distributors.This commit rewrites the
GoldMinerclass to have aninitializemethod that receives the explorer, smith, and distributor as arguments. It also adds a#minemethod that orchestrates the mining process.