Rails 6.1.1 #1061
Closed
Rails 6.1.1 #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not convinced the build failures are related to anything I did. What's the status of CI? |
mike-burns
force-pushed
the
rails-6
branch
3 times, most recently
from
bec391d to
6e98608
Compare
|
Some of these tests are failing because the |
|
That's because of rails/rails#35285, which swapped from Thor |
mike-burns
added a commit
that referenced
this pull request
Mar 13, 2021
For too long we have [suffered] under the tyranny of Rails' mediocre `gem` action! But Rails 6 took it a step too far: it [no longer] supports a `destroy` generator. [suffered]: #915 [no longer]:#1061 (comment) So it's high time we make our own. In the process, encode the rules we like to see: keep gems alphabetical, and use the `group` block syntax instead of the `:group` argument. When inserting a gem, we have to consider two cases: do we have a group specification? If we don't have a group name, insert it alphabetically before the first non-indented `gem "..."` declaration. If we do have a group name, find the block for that group and insert it alphabetically. But there's also the chance thar we are the first to add this group, in which case we should add the group with the `gem` line at the end. When removing a group, we again consider the groups case. If there is no group specification, remove the first matching non-indented `gem "..."` declaration. If we have a group spec, find the group block in the Gemfile and remove it. If there is no such group block, do nothing. Closes #915.
Closed
|
Fixing it in #1066. |
Along the way some tiny changes were made: - Use [`config.i18n.raise_on_missing_translations`] instead of the deprecated setting. - Better print-debugging in the test suite for the `destroy` task. [`config.i18n.raise_on_missing_translations`]: rails/rails#31571
In [this commit] ActiveJob::LogSubscriber was extracted to a separate class and now needs to be required explicitly. [this commit]: rails/rails@e8b3a46#diff-607cb532b6032217dc132c06d6822726cdd173c1907c09bddae078e436c50e03
|
We might want to consider closing this now that #1104 has been merged. |
|
We Rails 7 now, hey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the way some tiny changes were made:
config.i18n.raise_on_missing_translationsinstead of thedeprecated setting.
config.asset_host.destroytask.Closes #1060 .