This repository has been archived by the owner on Feb 14, 2025. It is now read-only.
SCAL-233969: Add preauth info call, emit Info call success event Iframe load #100
+312
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
utsavkapoor
approved these changes
Jan 27, 2025
…PreauthCache to control cache from Embed params
| @@ -167,6 +172,7 @@ export async function notifyAuthSuccess(): Promise<void> { | |||
| return; | |||
| } | |||
| try { | |||
| getPreauthInfo(); | |||
| const sessionInfo = await getSessionInfo(); | |||
There was a problem hiding this comment.
Can we replace this getSessionInfo with the getPreauthInfo here? Better to avoid multiple api calls.
There was a problem hiding this comment.
Or update the getSessionInfo to call getPreauthInfo internally and replace the dependency on old /info call
There was a problem hiding this comment.
This is decided with TSE to keep both APIs as older customers won't have preauth info API. Check more detail here - https://thoughtspot.slack.com/archives/C082G97N8BZ/p1732810938126219
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.