add the missing option to let user exclude dot files #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,7 +59,7 @@ module.exports = function(grunt) { | |||
| files = fs.readdirSync(startDir); | |||
| for (i = 0; i < files.length; i++) { | |||
| currFile = startDir + path.sep + files[i]; | |||
| if (!file.isMatch({matchBase: true}, exclusions, currFile)) { | |||
| if (!file.isMatch({matchBase: true,dot:true}, exclusions, currFile)) { | |||
There was a problem hiding this comment.
just a nitpick that there should be a space after the comma.
|
I think that some users might want to transfer their hidden files. This is probably better as an option rather than forcing it for all uploads. |
|
So old. I totally forgot about this. Indeed, i agree an option would be better. For syntax i suggest eslint for code style check. |
|
good idea to add a jshint config file. thanks. |
|
eslint much better in my mind : ) Have an example here https://github.com/cozy-labs/cozy-light/blob/master/.eslintrc and have the website there http://eslint.org/docs/rules/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #31