change url for terms and conditions from threefold library to manual

[mik-tf]

Description

• Changed the URL for the Terms and Conditions from Library to Manual

Related Issues

• Update Links for T&C on Dashboard #3686

Preliminary Checks:

• Does it completely address the issue linked?
  • IMO, it should work but please test.

Checklist

• Tests included
• Build pass
• Documentation
• Code format and docstrings
• Screenshots/Video attached (needed for UI changes)

[0oM4R]

we should have this update in dashboard as well,

tfgrid-sdk-ts/packages/playground/src/weblets/profile_manager.vue

Lines 859 to 876 in 4e2fc0b

	function parseAcceptTermsLink(tempDiv: HTMLDivElement) {
	const url = "https://library.threefold.me/info/legal#";
	const linkElements = tempDiv.querySelectorAll("a");
	linkElements.forEach(linkElement => {
	const currentDomainMatch = linkElement.href.match(/^(https?:\/\/[^\\/]+)/);
	if (
	(currentDomainMatch && linkElement.href.includes("localhost")) ||
	(currentDomainMatch && linkElement.href.includes("dashboard")) // To update only internal links
	) {
	const currentDomain = currentDomainMatch[1];
	linkElement.href = linkElement.href.replace(currentDomain, url);
	}
	});
	}
	watch(openAcceptTerms, async () => {
	if (openAcceptTerms.value) {
	try {
	const url = "https://library.threefold.me/info/legal/";

[mik-tf]

@0oM4R I updated the two URLs from library to manual.

LMK if it's OK. And feel free to test it on your end. Thanks.

[maayarosama]

The terms and condition page can't be retrieved and when I press accept terms and conditions it fails
dashboard (2).log

[0oM4R]

it wont work; i think we should have markdown file to be able to parse it

[0oM4R]

also looks like the host have cors error

[0oM4R]

CORS error resolved, we may see the error as the current appends readme.md to the link, if you commented this part you will not face the cors error again, but the content will be shown as html file

[mik-tf]

@0oM4R Can you please tell me more info on what I need to do here to fix it? I am not sure I understand exactly what to comment. Thanks.

[0oM4R]

@mik-tf Can we mark this PR as a draft until the comments get resolved?

[mik-tf]

@0oM4R Of course. Done.

[mik-tf]

@0oM4R as I understand, the issue on cors has been resolved. I'll wait for your input before setting it to Ready to review, to be sure. Thanks.

[0oM4R]

@0oM4R as I understand, the issue on cors has been resolved. I'll wait for your input before setting it to Ready to review, to be sure. Thanks.
@mik-tf
already reviewed the pr and mentioned the current issue on #3687 (comment)

[maayarosama]

The related issue's state is accepted, shouldn't this pr be drafted?

[mik-tf]

Hi! As I understand we can go forward with this PR. Please check if everything is OK.

[maayarosama]

Still not working

[0oM4R]

@mik-tf Please make sure to update the issue status; also if the pr is not ready please make sure to move it to draft and update the issue status as well,
I will assign the issue to you as you have the pr ready now Please make sure to update the status

[mik-tf]

@0oM4R ok good. but can you check the reply above? I asked you some guidance lately and didn't have any feedback yet.

For now, I do not know how to fix the issue. So I would appreciate more information from the dev team, if possible. Thanks!

My question is here: #3687 (comment)

Thanks for all the help btw.

[0oM4R]

@0oM4R ok good. but can you check the reply above? I asked you some guidance lately and didn't have any feedback yet.

For now, I do not know how to fix the issue. So I would appreciate more information from the dev team, if possible. Thanks!

My question is here: #3687 (comment)

Thanks for all the help btw.

Sure, the main point is we need the link to be a link for a markdown file; as i mentioned here: #3687 (comment)

the current logic do not support extracting html content so the mentioned link will not work

[mik-tf]

Closing this PR in favor of #3866.

It should be cleaner.