Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wallet provider instead of fn propagation #822

Merged
merged 8 commits into from
Jan 14, 2025
Merged

Use wallet provider instead of fn propagation #822

merged 8 commits into from
Jan 14, 2025

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Dec 24, 2024 •
edited
Loading

Changes

  • Remove props from all wallet screens
  • Add clear function to wallets provider

Related Issues

Tested Scenarios

A list of scenarios tried to match the deliverables

@zaelgohary zaelgohary changed the title Development_use_wallet_provider Use wallet provider instead of fn propagation Dec 24, 2024
Base automatically changed from development_refactor_wallet_provider to development December 29, 2024 14:49
@zaelgohary zaelgohary marked this pull request as ready for review December 30, 2024 09:24
AhmedHanafy725
AhmedHanafy725 requested changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The provider should have a method for editing the wallet name. We shouldn't wait until the reload balance is called to update the name.
  • Adding a new wallet doesn't use the provider.

@zaelgohary zaelgohary marked this pull request as draft December 31, 2024 07:36
@zaelgohary zaelgohary marked this pull request as ready for review January 5, 2025 23:00
@AhmedHanafy725 AhmedHanafy725 mentioned this pull request Jan 8, 2025
Merged
AhmedHanafy725
AhmedHanafy725 reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the wallet name doesn't update in the appBar after editing

Screenrecorder-2025-01-08-13-20-13-609.mp4

@zaelgohary
Copy link
Contributor Author

the wallet name doesn't update in the appBar after editing

I added a watcher to the wallet to reload the details on any change.

@zaelgohary zaelgohary merged commit 39e3b9b into development Jan 14, 2025
1 check passed
@zaelgohary zaelgohary deleted the development_use_wallet_provider branch January 14, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaelgohary @AhmedHanafy725