Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix adding existing stellar secret #843

Merged
merged 3 commits into from
Jan 19, 2025
Merged

fix adding existing stellar secret #843

merged 3 commits into from
Jan 19, 2025

Conversation

AlaaElattar
Copy link
Contributor

@AlaaElattar AlaaElattar commented Jan 8, 2025 •
edited
Loading

Changes

  • The stellar secret of 12 mnemonic wallet was added again without an error.
  • Added a condition to check the provided stellar secret with existing ones

Related Issues

Tested Scenarios

  • Tested with secret seed of 12 mnemonic account.
  • Tested with secret seed of 24 mnemonic account.

zaelgohary
zaelgohary reviewed Jan 19, 2025
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a wallet using a 12-word mnemonic, then used the same Stellar secret to import a new wallet after removing the first one. Despite another wallet with the same secret already existing, I was able to import the same wallet using the 12-word mnemonic.

image

image

zaelgohary
zaelgohary approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous comment is a known issue.

@AlaaElattar AlaaElattar merged commit 6f79360 into development Jan 19, 2025
1 check passed
@AlaaElattar AlaaElattar deleted the development_stellar_secret branch January 19, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary zaelgohary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlaaElattar @zaelgohary @AhmedHanafy725