improve phone number verification counter #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaelgohary
reviewed
Jan 19, 2025
Comment on lines
1085
to
1097
| if (remainingTime > 0) { | ||
| String formattedTime; | ||
| if (remainingTime >= 60) { | ||
| int minutes = remainingTime ~/ | ||
| 60; | ||
| int seconds = remainingTime % | ||
| 60; | ||
| formattedTime = | ||
| '${minutes}m ${seconds}s'; | ||
| } else { | ||
| formattedTime = | ||
| '${remainingTime}s'; | ||
| } |
There was a problem hiding this comment.
Can we export the logic here in an outer function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Related Issues
Tested Scenarios
verifyand waited for the timer and was counting right.verifythen leaved the page and return again, the counter was counting right.