-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] dApp-friendly contract deployment #118
Draft
r-czajkowski
wants to merge
9
commits into
main
Choose a base branch
from
dapp-development
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+30
−2
Draft
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
beded5c
Fine-tuned unstake period
r-czajkowski a9a29a0
Add script that sets the min stake amount
r-czajkowski f9411c0
Add `CODEOWNERS` file
r-czajkowski c5bdf3d
Fix script
r-czajkowski 9025679
Merge remote-tracking branch 'origin/main' into dapp-development
michalinacienciala 18c679d
Change version's suffix to `-dapp-dev-goerli`
michalinacienciala eea1ea8
Merge branch 'main' into dapp-development
r-czajkowski 65f6431
Merge remote-tracking branch 'origin/main' into dapp-development
michalinacienciala 646a5c6
Switch to `dapp-dev-sepolia`
michalinacienciala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import { HardhatRuntimeEnvironment } from "hardhat/types" | ||
import { DeployFunction } from "hardhat-deploy/types" | ||
|
||
const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) { | ||
const { getNamedAccounts, deployments } = hre | ||
const { execute } = deployments | ||
const { log } = deployments | ||
|
||
const { deployer } = await getNamedAccounts() | ||
|
||
const minStakeAmount = "39999999999999999999999" | ||
await execute( | ||
"TokenStaking", | ||
{ from: deployer }, | ||
"setMinimumStakeAmount", | ||
minStakeAmount | ||
) | ||
|
||
log(`Set minimum stake amount to ${minStakeAmount}`) | ||
} | ||
|
||
export default func | ||
|
||
func.tags = ["setMinStakeAmount"] | ||
func.dependencies = ["TokenStaking"] | ||
func.skip = async function (hre: HardhatRuntimeEnvironment): Promise<boolean> { | ||
return hre.network.name !== "sepolia" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we want to set the minimum stake to 39999999999999999999999? With dApp team owning T token contract from
dapp-development-goerli
deployment, all devs should be able to mint any amount of T they want.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
39999999999999999999999
is the current min stake on mainnet that's why I picked this number but we could change to any number. We want to set the min stake to test the min stake validation in T dapp.