Skip to content

Commit

Permalink
Merge pull request #531 from threshold-network/no-longer-ignore-scripts
Browse files Browse the repository at this point in the history
Don't run postinstall script separately from `yarn install`
  • Loading branch information
lukasz-zimnoch authored Oct 24, 2023
2 parents 8652343 + 17e2a0b commit b24fdc3
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 14 deletions.
7 changes: 2 additions & 5 deletions .github/workflows/dashboard-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,7 @@ jobs:
run: git config --global url."https://".insteadOf git://

- name: Install dependencies
run: yarn install --ignore-scripts --frozen-lockfile

- name: Run token-dashboard post-install script
run: yarn run postinstall
run: yarn install --frozen-lockfile

- name: Check formatting
run: yarn format
Expand Down Expand Up @@ -80,7 +77,7 @@ jobs:
@keep-network/tbtc-v2 \
@keep-network/tbtc-v2.ts \
@keep-network/ecdsa \
@keep-network/random-beacon --ignore-scripts
@keep-network/random-beacon
- name: Run postinstall script
# `yarn upgrade` doesn't trigger the `postinstall` script.
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/dashboard-mainnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,7 @@ jobs:
run: git config --global url."https://".insteadOf git://

- name: Install dependencies
run: yarn install --ignore-scripts --frozen-lockfile

- name: Run token-dashboard post-install script
run: yarn run postinstall
run: yarn install --frozen-lockfile

# FIXME: It's work in progress, the contracts are not yet published.
# - name: Resolve latest mainnet contracts
Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/reusable-build-and-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,7 @@ jobs:

- name: Install dependencies
shell: bash
run: yarn install --ignore-scripts --frozen-lockfile

- name: Run token-dashboard post-install script
shell: bash
run: yarn run postinstall
run: yarn install --frozen-lockfile

- name: Get upstream packages versions
if: inputs.useUpstreamBuilds == true
Expand Down

0 comments on commit b24fdc3

Please sign in to comment.