Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tBTC app modal refinements #630

Merged
merged 11 commits into from
Oct 30, 2023
Merged

New tBTC app modal refinements #630

merged 11 commits into from
Oct 30, 2023

Conversation

kpyszkowski
Copy link
Contributor

@kpyszkowski kpyszkowski commented Oct 2, 2023 •
edited
Loading

Closes: #547

Added "How it works" button for NewTBTCApp modal component. Reordered sub navigation links. Changed default page for tBTC section.

@kpyszkowski kpyszkowski mentioned this pull request Oct 2, 2023
Closed
@kpyszkowski kpyszkowski self-assigned this Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Preview uploaded to https://preview.dashboard.test.threshold.network/feature/new-tbtc-app-modal-refinements/index.html.

michalsmiarowski
michalsmiarowski requested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments to look at down below 👇

src/components/SubNavigationPills/index.tsx Outdated Show resolved Hide resolved
src/components/SubNavigationPills/index.tsx Outdated Show resolved Hide resolved
src/components/SubNavigationPills/index.tsx Outdated Show resolved Hide resolved
@michalsmiarowski
Copy link
Contributor

We should also make "How it works" subpage a primary page when you click "tBTC" on the left navigation. Right now when you click it it automatically goes to "Bridge" subpage.

@michalsmiarowski michalsmiarowski added this to the v1.12.0 milestone Oct 18, 2023
michalsmiarowski
michalsmiarowski requested changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now 🔥 Left some comments to look at before the merge though

src/components/Modal/tBTC/NewTBTCApp.tsx Outdated Show resolved Hide resolved
src/pages/tBTC/HowItWorks/index.tsx Outdated Show resolved Hide resolved
src/components/SubNavigationPills/index.tsx Outdated Show resolved Hide resolved
src/components/Modal/tBTC/NewTBTCApp.tsx Outdated Show resolved Hide resolved
@michalsmiarowski
Copy link
Contributor

@kpyszkowski Let's also merge the newest changes from main branch to fix the build

@kpyszkowski
Copy link
Contributor Author

@michalsmiarowski The main branch has been merged into feature branch, ref commit: d17d9b3

@github-actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/feature/new-tbtc-app-modal-refinements/index.html.

1 similar comment
@github-actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/feature/new-tbtc-app-modal-refinements/index.html.

michalsmiarowski
michalsmiarowski requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one small issue to fix before the merge

src/components/Modal/tBTC/NewTBTCApp.tsx Show resolved Hide resolved
@kpyszkowski
Remove UI element according to design updates
17d2374 
Removed "Bridging back BTC is back" list item from `TakeNoteList`
component
@github-actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/feature/new-tbtc-app-modal-refinements/index.html.

@michalsmiarowski michalsmiarowski self-requested a review October 30, 2023 10:50
michalsmiarowski
michalsmiarowski approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@michalsmiarowski michalsmiarowski merged commit 90b33fb into main Oct 30, 2023
5 checks passed
@michalsmiarowski michalsmiarowski deleted the feature/new-tbtc-app-modal-refinements branch October 30, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsmiarowski michalsmiarowski michalsmiarowski approved these changes

Assignees

@kpyszkowski kpyszkowski

Labels
None yet
Projects
None yet
Milestone
v1.12.0
Development

Successfully merging this pull request may close these issues.

Bring "How it works" page to forefront
2 participants
@kpyszkowski @michalsmiarowski