Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staking user flow enhancements - running node acknowledgement #632

Merged
merged 17 commits into from
Oct 30, 2023

Conversation

kpyszkowski
Copy link
Contributor

Ref: #567

Added running node alert box and adjusted modal labeling. Added acknowledgement checkbox and conditionally disabled Continue button.

@kpyszkowski kpyszkowski force-pushed the feature/staking-running-node-notice branch from d558aa0 to bbfdb1e Compare October 3, 2023 08:57
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Adjust styles to match design, fix ModalCloseButton component props passing, replace FlowStep components content whitespaces with HTML entites.
Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments to look at before the merge

src/components/Modal/ConfirmStakingParams/index.tsx Outdated Show resolved Hide resolved
src/components/Modal/ConfirmStakingParams/index.tsx Outdated Show resolved Hide resolved
src/components/Modal/StakingChecklistModal/index.tsx Outdated Show resolved Hide resolved
src/components/Modal/StakingChecklistModal/index.tsx Outdated Show resolved Hide resolved
src/components/Modal/StakingChecklistModal/index.tsx Outdated Show resolved Hide resolved
src/components/Modal/StakingChecklistModal/index.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left some comments to look at before the merge though.

src/components/Modal/SubmitStake/index.tsx Outdated Show resolved Hide resolved
src/components/StakingTimeline/index.tsx Outdated Show resolved Hide resolved
src/components/StakingTimeline/index.tsx Outdated Show resolved Hide resolved
src/components/StakingTimeline/index.tsx Outdated Show resolved Hide resolved
src/components/Link/SharedLinks.tsx Outdated Show resolved Hide resolved
src/components/Modal/StakingChecklistModal/index.tsx Outdated Show resolved Hide resolved
src/components/Modal/SubmitStake/index.tsx Outdated Show resolved Hide resolved
src/components/StakingTimeline/index.tsx Outdated Show resolved Hide resolved
src/components/StakingTimeline/index.tsx Outdated Show resolved Hide resolved
src/components/StakingTimeline/index.tsx Outdated Show resolved Hide resolved
@michalsmiarowski
Copy link
Contributor

@kpyszkowski Let's also merge the newest changes from main branch to fix the build

@kpyszkowski kpyszkowski force-pushed the feature/staking-running-node-notice branch from 3f3183a to 3f54fc9 Compare October 23, 2023 09:49
@github-actions
Copy link

1 similar comment
@github-actions
Copy link

Transformed heading element into paragraph element. Added color variant
for dark mode.
@github-actions
Copy link

@github-actions
Copy link

1 similar comment
@github-actions
Copy link

@michalsmiarowski michalsmiarowski added this to the v1.12.0 milestone Oct 30, 2023
Wrapped `FlowStep`'s content with `BodySm` component
@github-actions
Copy link

1 similar comment
@github-actions
Copy link

Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@michalsmiarowski michalsmiarowski merged commit be733a9 into main Oct 30, 2023
5 checks passed
@michalsmiarowski michalsmiarowski deleted the feature/staking-running-node-notice branch October 30, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants