-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staking user flow enhancements - running node acknowledgement #632
Conversation
d558aa0
to
bbfdb1e
Compare
1 similar comment
Adjust styles to match design, fix ModalCloseButton component props passing, replace FlowStep components content whitespaces with HTML entites.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments to look at before the merge
This reverts commit bbfdb1e.
Adjust styled to match design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Left some comments to look at before the merge though.
@kpyszkowski Let's also merge the newest changes from |
3f3183a
to
3f54fc9
Compare
1 similar comment
Transformed heading element into paragraph element. Added color variant for dark mode.
1 similar comment
Wrapped `FlowStep`'s content with `BodySm` component
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
Ref: #567
Added running node alert box and adjusted modal labeling. Added acknowledgement checkbox and conditionally disabled Continue button.