Fix application status error on stake details page #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug that caused inaccuracies in the statuses of the tbtc and random beacon apps on the stake detail page. When you refresh the details page for a stake that the apps were not authorized for, it incorrectly displays them as authorized. This issue resolves itself when you navigate to the authorization or staking page and then return to the details page. The issue arises from the fact that we did not dispatch the `getSupportedApps` action on the detail page. Consequently, the `getSupportedAppsEffect` was not triggered, leading to the `minimumAuthorization` value being set to 0 in the `selectStakingAppByStakingProvider` selector. This results in the `isAuthorized` flag being set to false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug that caused inaccuracies in the statuses of the tbtc and random beacon apps on the stake detail page. When you refresh the details page for a stake that the apps were not authorized for, it incorrectly displays them as authorized:
This issue resolves itself when you navigate to the authorization or staking page and then return to the details page:
The issue arises from the fact that we did not dispatch the
getSupportedAppsaction on the detail page. Consequently, thegetSupportedAppsEffectwas not triggered, leading to theminimumAuthorizationvalue being set to 0 in theselectStakingAppByStakingProviderselector. This results in theisAuthorizedflag being set to true:token-dashboard/src/store/staking-applications/selectors.ts
Lines 38 to 42 in 4f9b5cb