Add usage of DynamiHTML in remix #1114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+15
to
+17
| return unicodeString | ||
| .replaceAll(/\\u005C/g, "\\\\") | ||
| .replaceAll(/\\u0027/g, `\\`) |
Check failure
Code scanning / CodeQL
Double escaping or unescaping High
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| export function replaceDjangoUnicode(unicodeString: string) { | ||
| return unicodeString | ||
| .replaceAll(/\\u005C/g, "\\\\") | ||
| .replaceAll(/\\u0027/g, `\\`) |
There was a problem hiding this comment.
The unicode escape sequence \u0027 represents a single quote character ('), but this code incorrectly replaces it with a backslash (\). The replacement string should be ' instead of \\ to maintain the original meaning of the text.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Comment on lines
+144
to
+146
| __html: parsedLoaderOutput.dynamicBodyBeginning.map((dhtml) => | ||
| replaceDjangoUnicode(dhtml) | ||
| ), |
There was a problem hiding this comment.
The array of strings needs to be concatenated to avoid unwanted commas in the rendered HTML. Consider updating to:
__html: parsedLoaderOutput.dynamicBodyBeginning.map((dhtml) => replaceDjangoUnicode(dhtml)).join('')Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.