Add UploadPackageForm form and separate form functionality from layout #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oksamies
force-pushed
the
upload-package-form-continuance
branch
from
9dedd6b to
133915f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Oksamies
force-pushed
the
upload-package-form-continuance
branch
from
133915f to
64da761
Compare
Oksamies
force-pushed
the
upload-package-form-continuance
branch
from
64da761 to
ba4e90c
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+57
to
+59
| selected.map( | ||
| (x) => (communityCategories["community_identifier"] = [x.value]) | ||
| ); |
There was a problem hiding this comment.
The communityCategories object is using a hardcoded key "community_identifier" which overwrites the same key on each iteration. The selected values should include both the community and category IDs, likely in a format like "communityId:categoryId", allowing the parser to split this into the correct community-to-categories mapping.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PRs have to be merged, before this can be rebased and went through:
#919
#928
#929
#930
#931